Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join of base url for windows machines #282

Merged
merged 1 commit into from
May 2, 2024

Conversation

TheHappyLemon
Copy link
Contributor

Found this issue, when installing laser2 model. Because my spm file was XML with errors, I decided to check the script itself. Figured out that the link to download is formed incorrectly, because on windows os.path.join will use "" insted of "/"

@facebook-github-bot
Copy link

Hi @TheHappyLemon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@TheHappyLemon
Copy link
Contributor Author

I signed the CLA

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 25, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@avidale
Copy link
Contributor

avidale commented Apr 26, 2024

Thanks @TheHappyLemon for your fix!
Would you be so kind to confirm that with it, downloading and using LASER models works on Windows?
If it is the case, your PR would also close the issue #255.

@TheHappyLemon
Copy link
Contributor Author

@avidale Yes, I do confirm that it successfully downloads on Windows now!

Copy link
Contributor

@avidale avidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that laser_encoders didn't work on Windows without this fix, and it is working now.
Thanks for spotting and fixing this problem!

@avidale avidale merged commit 982fb46 into facebookresearch:main May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants