-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop opt service #517
Loop opt service #517
Conversation
Codecov Report
@@ Coverage Diff @@
## development #517 +/- ##
===============================================
- Coverage 87.36% 87.31% -0.05%
===============================================
Files 113 113
Lines 6411 6411
===============================================
- Hits 5601 5598 -3
- Misses 810 813 +3
Continue to review full report at Codecov.
|
2d574ff
to
3f5c04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I left some small nitpicks inline
examples/loop_optimizations_service/service_py/loops_opt_service.py
Outdated
Show resolved
Hide resolved
3f5c04a
to
6f547a3
Compare
Thanks for the review. Rebased with master and addressed all comments. |
I just added a |
Woop, thanks @mostafaelhoushi! BTW just a tiny thing - could you submit future PRs from a fork, rather than branching off the main repo? That way it keeps the number of branches down (should be just development, stable, and gh-pages) to keep things clean for when others fork it. Thanks! Chris |
Yes, sure. I should have done that. I will make sure future PRs are from a fork. |
A dedicated CompilerGym service for loop optimizations:
Next steps for future PRs:
env.next_loop()
orenv.set_loops(i)
orenv.set_all_loops()
APIs to control which loops to optimize