-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Loop Unroller #477
Conversation
Codecov Report
@@ Coverage Diff @@
## development #477 +/- ##
===============================================
+ Coverage 87.75% 87.93% +0.17%
===============================================
Files 111 111
Lines 6181 6182 +1
===============================================
+ Hits 5424 5436 +12
+ Misses 757 746 -11
Continue to review full report at Codecov.
|
Update: Thanks for @hughleat for his help. Counting the loops is now solved. Next step is to update the loop metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a pick through the code and it all looks good to me (minor comments inline). I'm guessing with this being WIP that the glue code to interface with an environment is coming later. Just ping me whenever you want me to take a look through :-)
Cheers,
Chris
examples/example_unrolling_service/loop_unroller/loop_unroller.cc
Outdated
Show resolved
Hide resolved
examples/example_unrolling_service/loop_unroller/loop_unroller.cc
Outdated
Show resolved
Hide resolved
Thanks Chris. I have addressed all the comments. |
I merged it without pinging you :( |
No worries! Code looks great :) I'll try it out and let you know if i encounter any problems Cheers, |
We have noticed that the unrolling factor passed to
opt
as--unroll-count=<num>
cli option doesn't always take effect.This PR provides a custom LLVM loop unroller that enforces the unroll count factor provided in an action..
To run custom unroller:
To run end-to-end example: