Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running CompilerGym environments from docker containers #424

Merged
merged 12 commits into from
Sep 27, 2021

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented Sep 23, 2021

This adds a chriscummins/compiler_gym docker image that consists of a pre-configured CompilerGym install in a Python 3.8 Linux environment. Changes required to implement this:

  • Made Benchmark.from_file() compatible with distributed services.
  • Fixed compatibility of the --service and --local_service_bin flags.
  • Fixed an unrelated bug when changing reward space midway through an episode.
  • Added a --run_on_port flag to compiler_gym.bin.service.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #424 (ee42fd5) into development (03f0a3b) will decrease coverage by 0.01%.
The diff coverage is 67.64%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #424      +/-   ##
===============================================
- Coverage        87.29%   87.28%   -0.02%     
===============================================
  Files              100      100              
  Lines             5746     5763      +17     
===============================================
+ Hits              5016     5030      +14     
- Misses             730      733       +3     
Impacted Files Coverage Δ
compiler_gym/bin/random_search.py 0.00% <0.00%> (ø)
compiler_gym/service/connection.py 77.58% <ø> (+1.03%) ⬆️
compiler_gym/bin/service.py 76.27% <45.45%> (-7.41%) ⬇️
compiler_gym/util/flags/env_from_flags.py 89.58% <76.92%> (+4.16%) ⬆️
compiler_gym/datasets/benchmark.py 99.00% <100.00%> (+0.01%) ⬆️
compiler_gym/envs/compiler_env.py 88.27% <100.00%> (-0.30%) ⬇️
compiler_gym/spaces/reward.py 72.54% <0.00%> (-1.97%) ⬇️
compiler_gym/envs/llvm/llvm_env.py 85.24% <0.00%> (-0.82%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 97.37% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f0a3b...ee42fd5. Read the comment docs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2021
@ChrisCummins ChrisCummins force-pushed the docker branch 7 times, most recently from 0b2f780 to ad52816 Compare September 23, 2021 14:01
@ChrisCummins ChrisCummins changed the title 🏗️ WIP: Add support for running CompilerGym environments from docker containers Add support for running CompilerGym environments from docker containers Sep 23, 2021
@ChrisCummins ChrisCummins marked this pull request as ready for review September 23, 2021 15:20
@ChrisCummins ChrisCummins merged commit 60d9e8c into facebookresearch:development Sep 27, 2021
@ChrisCummins ChrisCummins deleted the docker branch September 27, 2021 13:57
This was referenced Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants