Improved error reporting from ObservationView.__getitem__(). #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves the error reporting when computing an observation fails. First, if the service produces an unexpected number of observations, a ServiceError is raised, rather than the previous assertion. Second, if the environment reports that it has reached a terminal state, a ServiceError is raised, containing the error details produced by the environment.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## development #380 +/- ##
===============================================
+ Coverage 85.81% 85.83% +0.02%
===============================================
Files 87 87
Lines 4757 4764 +7
===============================================
+ Hits 4082 4089 +7
Misses 675 675
Continue to review full report at Codecov.
|
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the error reporting when computing an observation fails. First, if the service produces an unexpected number of observations, a ServiceError is raised, rather than the previous assertion. Second, if the environment reports that it has reached a terminal state, a ServiceError is raised, containing the error details produced by the environment.