Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optional Tanh transfromed distributions in algorithms #45

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Jan 17, 2024

Added the possibility of choosing if continuous actions distributions should be Tanh trnasformed

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2024
@matteobettini matteobettini added the smacv2 Label to be assigned to run the SMACv2 tests label Jan 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (02fc1b6) 89.68% compared to head (76acbc7) 46.47%.

Files Patch % Lines
benchmarl/algorithms/iddpg.py 66.66% 1 Missing ⚠️
benchmarl/algorithms/ippo.py 66.66% 1 Missing ⚠️
benchmarl/algorithms/isac.py 66.66% 1 Missing ⚠️
benchmarl/algorithms/maddpg.py 66.66% 1 Missing ⚠️
benchmarl/algorithms/mappo.py 66.66% 1 Missing ⚠️
benchmarl/algorithms/masac.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   89.68%   46.47%   -43.21%     
===========================================
  Files          64       64               
  Lines        2656     2668       +12     
===========================================
- Hits         2382     1240     -1142     
- Misses        274     1428     +1154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini marked this pull request as ready for review January 17, 2024 09:42
@matteobettini matteobettini merged commit b10d37a into main Jan 17, 2024
12 checks passed
@matteobettini matteobettini deleted the choose_tanh branch January 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. smacv2 Label to be assigned to run the SMACv2 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants