Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] More callbacks #35

Merged
merged 5 commits into from
Nov 8, 2023
Merged

[Feature] More callbacks #35

merged 5 commits into from
Nov 8, 2023

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Nov 2, 2023

Introduced a training callback (that can be used for example to compute custom losses) and a callback for rendering during evaluation

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ea835d0) 89.17% compared to head (21cd5fd) 83.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   89.17%   83.29%   -5.88%     
==========================================
  Files          53       53              
  Lines        2420     2437      +17     
==========================================
- Hits         2158     2030     -128     
- Misses        262      407     +145     
Files Coverage Δ
benchmarl/experiment/logger.py 89.05% <ø> (-2.92%) ⬇️
benchmarl/experiment/experiment.py 89.44% <83.33%> (-2.49%) ⬇️
benchmarl/environments/common.py 66.66% <66.66%> (ø)
benchmarl/experiment/callback.py 62.16% <50.00%> (-7.07%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini marked this pull request as ready for review November 8, 2023 09:55
@matteobettini matteobettini merged commit 205db60 into main Nov 8, 2023
12 checks passed
@matteobettini matteobettini deleted the callback branch November 8, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants