Draft storage on disk option #155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This is great thanks a ton! Insetad of introducing a new arg (which you have to pass to experiments, benchmarks, etc) I would just use the existing "buffer_device" and check when it is == Another question I have is if you could check this works with chackpointing. Aka I see that when the experiment ends you delete the file, but if it the experiment had checkpointed, did it store it correctly in the checkpoint folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea of how to add an option to use disk storage for the replay buffer. It is not advisable to rely on temporary paths for this purpose, as some operating systems impose limitations on their storage capacity.