Rename VectorSerializer to IterativeVectorSerializer to distinguish it from BatchVectorSerializer#8605
Closed
kevinwilfong wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53201916 |
…t from BatchVectorSerializer (facebookincubator#8605) Summary: To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916
kevinwilfong
force-pushed
the
export-D53201916
branch
from
0339320 to
613c005
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53201916 |
kevinwilfong
force-pushed
the
export-D53201916
branch
from
613c005 to
ce36c90
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53201916 |
Contributor
|
This pull request has been merged in 693452a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 10, 2024
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 10, 2024
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 12, 2024
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
makagonov
pushed a commit
to makagonov/velox
that referenced
this pull request
May 27, 2025
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer.
I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer.
Differential Revision: D53201916