-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade folly to v2023.12.04.00 (from v2022.11.14.00) #7700
Conversation
✅ Deploy Preview for meta-velox canceled.
|
@assignUser Jacob, thank you for the upgrade. Would you rebase and resolve conflicts? |
a759e76
to
7edd81c
Compare
The nodiscard was just added in facebook/folly@b7af40f so let's try a bit earlier version. |
Masha and I magically chose |
🧙 😀 nice. Yeah will try if this one fails |
And don't forget to update the setup scripts as well. |
This worked only on MacOS though. Linux was not tested. |
hmm @majetideepak any idea what could cause the glog issue? |
I found this link gflags/gflags#203 |
@assignUser I see that both gflags and glog are being built together even though there is a gflags dependency for glog.
|
Oh yeah that might be it! I'll check it out! |
16e7e75
to
4bbd0f8
Compare
@majetideepak looks like you were right! But we seem to have some other errors now... I had to add a new warning suppression to the expression fuzzer test (see commit message for the error) but we should probably just fix that. |
I am having a hard time trying to understand these warnings.
|
Is this relevant?
|
@mbasmanova thanks for the pointer. That is relevant. |
I am looking into the linux-build failure
|
4bbd0f8
to
46c0ab2
Compare
@majetideepak rebased and add the changes for the spark fuzzer. |
reverting the init change to the fuzzer files and adding |
Summary: fmt 8.0.1 is not upwards compatible to 9+ but backwards compatibility should not be an issue from what I could see in the logs and have done during #7700 (newst folly is compatible with fmt 10 but we built it with 8.0.1). Closes #7896 Pull Request resolved: #7941 Reviewed By: Yuhta Differential Revision: D52570200 Pulled By: kgpai fbshipit-source-id: 267840a66d05b03eb25c2c278a694d062770dcea
bump to newest version Revert "bump to newest version" This reverts commit 016f862. use 2023.10.30 use newest folly
this properly suppresses all warnings that happen within folly headers (e.g. openssl)
24c12c2
to
9edbfba
Compare
@kgpai @majetideepak could one of you look at the test failures and benchmark segfault? These are out of my wheelhouse. This PR was green before the rebase (300+ new commits) on the fmt upgrade (but I tested it with fmt 10 before and it worked fine). |
@assignUser No worries, I can take a look. |
@assignUser For some reason I see |
Ah good catch I must have dropped the wrong commit during the rebase. I will fix in a bit, maybe that solves the problems already! |
This reverts commit 3dec592.
@assignUser If you can fix the |
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…tor#7700) Summary: This version no longer uses deprecated openssl functions. (the actual change is in an earlier version but I think it makes sense to bump as far as possible while we are at it) Pull Request resolved: facebookincubator#7700 Reviewed By: Yuhta Differential Revision: D51966751 Pulled By: kgpai fbshipit-source-id: 33df50e9c6b92459247b7e578a453a2d24e0d6dc
This version no longer uses deprecated openssl functions. (the actual change is in an earlier version but I think it makes sense to bump as far as possible while we are at it)