Uniform return type of UDAF registration functions#7133
Uniform return type of UDAF registration functions#7133kagamiori wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
kagamiori
force-pushed
the
export-D50436492
branch
from
2fde971 to
025f639
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
kagamiori
force-pushed
the
export-D50436492
branch
from
025f639 to
ba26618
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
kagamiori
force-pushed
the
export-D50436492
branch
from
ba26618 to
e12b249
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
kagamiori
force-pushed
the
export-D50436492
branch
from
e12b249 to
8c188c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
…#7133) Summary: Make individual UDAF registration functions all return exec::AggregateRegistrationResult. Reviewed By: kevinwilfong Differential Revision: D50436492
kagamiori
force-pushed
the
export-D50436492
branch
from
8c188c3 to
cba5cf9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50436492 |
|
This pull request has been merged in 656ed8e. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
Can I ask why you modified UDAF registration functions all return exec::AggregateRegistrationResult, In addition, some functions such as registerVarianceAggregates have not been modified yet. How can they be modified in the future? |
3 participants
Summary: Make individual UDAF registration functions all return exec::AggregateRegistrationResult.
Differential Revision: D50436492