Skip to content

Add Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez time zones #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wypb wants to merge 1 commit into from
Closed

Add Pacific/Kanton, Europe/Kyiv, America/Ciudad_Juarez time zones #6670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions velox/type/tz/TimeZoneDatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2257,6 +2257,9 @@ const std::unordered_map<int64_t, std::string>& getTimeZoneDB() {
{2228, "Europe/Saratov"},
{2229, "Asia/Qostanay"},
{2230, "America/Nuuk"},
{2231, "Pacific/Kanton"},
{2232, "Europe/Kyiv"},
{2233, "America/Ciudad_Juarez"},
};
return tzDB;
}
Expand Down
5 changes: 3 additions & 2 deletions velox/type/tz/gen_timezone_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@
// > velox/type/tz/TimeZoneDatabase.cpp
//
// The zone-index.properties file should be the same one used in Presto,
// Available here : https://github.com/prestodb/presto/blob/master/presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties.
// Available here :
// https://github.com/prestodb/presto/blob/master/presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties.
// @generated

#include <unordered_map>
#include <string>
#include <unordered_map>

namespace facebook::velox::util {

Expand Down
6 changes: 6 additions & 0 deletions velox/type/tz/tests/TimeZoneMapTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,16 @@ namespace {
TEST(TimeZoneMapTest, simple) {
EXPECT_EQ("America/Los_Angeles", getTimeZoneName(1825));
EXPECT_EQ("Europe/Moscow", getTimeZoneName(2079));
EXPECT_EQ("Pacific/Kanton", getTimeZoneName(2231));
EXPECT_EQ("Europe/Kyiv", getTimeZoneName(2232));
EXPECT_EQ("America/Ciudad_Juarez", getTimeZoneName(2233));
EXPECT_EQ("-00:01", getTimeZoneName(840));

EXPECT_EQ(1825, getTimeZoneID("America/Los_Angeles"));
EXPECT_EQ(2079, getTimeZoneID("Europe/Moscow"));
EXPECT_EQ(2231, getTimeZoneID("Pacific/Kanton"));
EXPECT_EQ(2232, getTimeZoneID("Europe/Kyiv"));
EXPECT_EQ(2233, getTimeZoneID("America/Ciudad_Juarez"));
EXPECT_EQ(840, getTimeZoneID("-00:01"));
EXPECT_EQ(0, getTimeZoneID("+00:00"));
}
Expand Down