[Velox] Bring back OBJECT to velox_hive_connector#3094
Closed
gggrace14 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
[Velox] Bring back OBJECT to velox_hive_connector#3094gggrace14 wants to merge 1 commit intofacebookincubator:mainfrom
gggrace14 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
Without OBJECT label for velox_hive_conector, build of presto_server sees error like undefined reference to HiveTableHandle::HiveTableHandle(). facebookincubator#2897 added OBJECT, but the next PR facebookincubator#2845 removed it according to change history. Actually PR facebookincubator#2845 did not touch OBJECT according to the PR page. It is likely due to file merge of CMakeList.txt.
mbasmanova
approved these changes
Nov 4, 2022
Contributor
|
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without OBJECT label for velox_hive_conector, build of presto_server sees error like undefined reference to
HiveTableHandle::HiveTableHandle().
#2897 added OBJECT, but the next PR #2845 removed it according to change history.
Actually PR #2845 did not touch OBJECT according to the PR page. It is likely due to change merge of CMakeList.txt on GitHub.