Fix bison and flex dependencies in MacOS CI#2442
Closed
kevinwilfong wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Fix bison and flex dependencies in MacOS CI#2442kevinwilfong wants to merge 1 commit intofacebookincubator:mainfrom
kevinwilfong wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
force-pushed
the
update_version
branch
from
09dc7da to
dd74d6f
Compare
kevinwilfong
changed the title
kevinwilfong
force-pushed
the
update_version
branch
3 times, most recently
from
a33f29a to
ce2ec7a
Compare
kevinwilfong
force-pushed
the
update_version
branch
from
ce2ec7a to
334861d
Compare
kevinwilfong
changed the title
Contributor
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kgpai
approved these changes
Sep 2, 2022
Contributor
|
CC: @majetideepak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bison and flex come standard with MacOS. Out of caution, homebrew will not install the executables from these kegs into the bin directory on MacOS.
Due to this, the versions of bison and flex we've been using in CircleCI on MacOS have been the ones installed with the OS not the ones we installed with homebrew.
This change fixes the PATH we use when building to include the directories where homebrew installs the executables for these two libraries. It also updates the FLEX_INCLUDE_DIR environment variable used in cmake to point to the include directory for flex installed by homebrew.
I think we've been getting away with this because the versions that came with our MacOS image were new enough that they worked for our build, but now our dependencies require newer versions of the libraries.