fix: Change count metric from signed to unsigned (int64_t -> uint64_t)#16989
Open
rui-mo wants to merge 2 commits intofacebookincubator:mainfrom
Open
fix: Change count metric from signed to unsigned (int64_t -> uint64_t)#16989rui-mo wants to merge 2 commits intofacebookincubator:mainfrom
rui-mo wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
rui-mo
requested review from
bdice,
devavret,
karthikeyann,
majetideepak and
mhaseeb123
as code owners
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Build Impact AnalysisFull build recommended. Files outside the dependency graph changed:
These directories are not fully covered by the dependency graph. A full build is the safest option. Fast path • Graph from main@2352ca6e3794ad44611df76f2aa58fa78fe6d235 |
Collaborator
Author
|
Hi @Yuhta @peterenescu, a compatibility layer (prestodb/presto#27295) has been merged into Presto, which should unblock the Velox merge. Could you please re-import this PR? Thanks! |
|
@peterenescu has imported this pull request. If you are a Meta employee, you can view this in D99206627. |
Contributor
|
@rui-mo Looks like internally we are still behind. Let me rebase later today or tomorrow to see if changes are pulled |
Collaborator
Author
|
@peterenescu Got it. Thanks for your assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an unsigned type for the count metric while keeping int64_t for value
metrics. When the unit is kNone, negative values can be valid such as for delta-
type metrics, so int64_t remains appropriate. In contrast,
countshouldalways be non-negative. This PR also addresses potential overflow when
converting unsigned metrics to
RuntimeMetrics.Replace: #15536