Add sequence number conflict resolution for equality deletes#16872
Closed
apurva-meta wants to merge 4 commits intofacebookincubator:mainfrom
Closed
Add sequence number conflict resolution for equality deletes#16872apurva-meta wants to merge 4 commits intofacebookincubator:mainfrom
apurva-meta wants to merge 4 commits intofacebookincubator:mainfrom
Conversation
Summary: - Add explicit equality deletes NYI branch in prepareSplit() - Improve VELOX_NYI error messages with descriptive content type info - Fix FILE handle leaks in IcebergReadTest by extracting getTestFileSize() helper - Minor doc comment formatting improvements in IcebergSplitReader.h Differential Revision: D97530140
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@apurva-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97530136. |
apurva-meta
force-pushed
the
export-D97530136
branch
from
903a788 to
4cc5825
Compare
meta-codesync
bot
changed the title
apurva-meta
force-pushed
the
export-D97530136
branch
2 times, most recently
from
3257856 to
697cc59
Compare
apurva-meta
force-pushed
the
export-D97530136
branch
from
697cc59 to
b509734
Compare
added 2 commits
March 24, 2026 13:12
Summary: Add deletion vector (DV) reader to the Velox Iceberg connector, enabling Iceberg V3 spec support for row-level deletes. Iceberg V3 replaces positional delete files with deletion vectors — compact roaring bitmaps stored as blobs inside Puffin files. Compared to V2 positional delete files, DVs are more compact and avoid sorted merge of multiple delete files at read time. Changes: - IcebergDeleteFile.h: Add FileContent::kDeletionVector enum value - DeletionVectorReader.h/cpp: New reader that loads a Puffin blob, deserializes the roaring bitmap portable format (array, bitset, and run containers), and sets bits in the deleteBitmap for the current batch range. No CRoaring dependency — self-contained parser. - IcebergSplitReader.h: Add deletionVectorReaders_ member, include header - IcebergSplitReader.cpp: Route kDeletionVector in prepareSplit(), apply DVs alongside positional deletes in next() - BUCK: Add DeletionVectorReader library target Differential Revision: D97530142
Summary: Implements Iceberg equality delete support for the Velox Iceberg connector. Equality delete files contain rows with values for one or more columns (identified by equalityFieldIds). A base data row is deleted if its values match ALL specified columns of ANY row in the delete file. The implementation: - Adds EqualityDeleteFileReader that eagerly reads the entire delete file and builds an in-memory hash multimap of delete key tuples during construction. - Wires EqualityDeleteFileReader into IcebergSplitReader::prepareSplit() to resolve equalityFieldIds to column names/types from the table schema, and into IcebergSplitReader::next() to apply post-read equality delete filtering with row compaction. - Handles lazy vectors from file readers via loadedVector() before accessing values for hashing and comparison. - Supports BOOLEAN, TINYINT, SMALLINT, INTEGER, BIGINT, REAL, DOUBLE, VARCHAR, VARBINARY, and TIMESTAMP column types. Differential Revision: D97530141
18 tasks
apurva-meta
force-pushed
the
export-D97530136
branch
from
b509734 to
5bf42ce
Compare
Summary: Implements Iceberg V2+ sequence number conflict resolution for equality delete files. Per the Iceberg spec, an equality delete file should only be applied to data files whose data sequence number is strictly less than the delete file's data sequence number. This prevents concurrent write conflicts where a delete file written concurrently with a data file could incorrectly delete rows that were not intended to be deleted. Changes: - Added `dataSequenceNumber` field to `IcebergDeleteFile` struct with default value 0 (unassigned/legacy V1). When 0, sequence number filtering is disabled for backward compatibility. - Added `dataSequenceNumber` field to `HiveIcebergSplit` to carry the base data file's sequence number. - Updated `IcebergSplitReader::prepareSplit()` to skip equality delete files when `deleteFile.dataSequenceNumber <= split.dataSequenceNumber` (unless either is 0, which disables the check). - Updated test constructor of `HiveIcebergSplit` to accept the new `dataSequenceNumber` parameter. Differential Revision: D97530136
meta-codesync
bot
changed the title
apurva-meta
force-pushed
the
export-D97530136
branch
from
5bf42ce to
99c6bbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implements Iceberg V2+ sequence number conflict resolution for equality
delete files. Per the Iceberg spec, an equality delete file should only
be applied to data files whose data sequence number is strictly less
than the delete file's data sequence number. This prevents concurrent
write conflicts where a delete file written concurrently with a data
file could incorrectly delete rows that were not intended to be deleted.
Changes:
dataSequenceNumberfield toIcebergDeleteFilestruct withdefault value 0 (unassigned/legacy V1). When 0, sequence number
filtering is disabled for backward compatibility.
dataSequenceNumberfield toHiveIcebergSplitto carry thebase data file's sequence number.
IcebergSplitReader::prepareSplit()to skip equality deletefiles when
deleteFile.dataSequenceNumber <= split.dataSequenceNumber(unless either is 0, which disables the check).
HiveIcebergSplitto accept the newdataSequenceNumberparameter.Differential Revision: D97530136