feat: Implement ParquetReader::columnStatistics()#16700
Closed
mbasmanova wants to merge 2 commits intofacebookincubator:mainfrom
Closed
feat: Implement ParquetReader::columnStatistics()#16700mbasmanova wants to merge 2 commits intofacebookincubator:mainfrom
mbasmanova wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95950333. |
…ookincubator#16693) Summary: The DWRF writer's StatisticsBuilder contains merge/addValues logic that is format-agnostic, but lives in the DWRF writer library, creating an undesirable cross-format dependency for consumers like Axiom and Parquet. This change extracts the format-agnostic parts into new dwio::common classes: - StatisticsBuilder base class with merge(), reset(), create(), createTree() - Typed builders: Boolean, Integer, Double, String, Binary - build() method that produces read-only ColumnStatistics snapshots The DWRF builders now extend the common base, adding only toProto() and proto-based build() for DWRF file format serialization. Axiom's StatisticsBuilderImpl now wraps dwio::common::StatisticsBuilder, removing the DWRF writer dependency. Differential Revision: D95885404
…16700) Summary: Implement ParquetReader::columnStatistics() which previously returned nullptr. The method merges per-row-group Parquet statistics into file-level statistics using StatisticsBuilder. Also improve the columnStatistics() API documentation in Reader.h to clarify the index parameter semantics. Differential Revision: D95950333
mbasmanova
force-pushed
the
export-D95950333
branch
from
5a7c2fa to
dd2ba13
Compare
Yuhta
approved these changes
Mar 10, 2026
PingLiuPing
approved these changes
Mar 10, 2026
Collaborator
PingLiuPing
left a comment
PingLiuPing
left a comment
There was a problem hiding this comment.
Thanks.
Looks like #16693 should be landed first.
|
This pull request has been merged in 91b2e45. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Summary: PR #16700 added support for Parquet file-level column statistics via `ParquetReader::columnStatistics()`. This PR adds an end-to-end test that verifies entire Parquet files are pruned during table scan when file-level column statistics allow the filter to eliminate all data in a file. Pull Request resolved: #16709 Reviewed By: apurva-meta, srsuryadev Differential Revision: D96560581 Pulled By: pedroerp fbshipit-source-id: d28d3792f63f2550f02212f36e025c7cf3f60087
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implement ParquetReader::columnStatistics() which previously returned nullptr.
The method merges per-row-group Parquet statistics into file-level statistics
using StatisticsBuilder. Also improve the columnStatistics() API documentation
in Reader.h to clarify the index parameter semantics.
Differential Revision: D95950333