Skip to content

refactor: Add format-agnostic StatisticsBuilder to dwio/common #16693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbasmanova wants to merge 1 commit into from
Closed

refactor: Add format-agnostic StatisticsBuilder to dwio/common #16693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions velox/dwio/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ velox_add_library(
SelectiveStructColumnReader.cpp
SortingWriter.cpp
SortingWriter.h
StatisticsBuilder.cpp
Throttler.cpp
TypeUtils.cpp
TypeWithId.cpp
Expand All @@ -76,6 +77,7 @@ velox_link_libraries(
velox_common_io
velox_common_compression
velox_common_config
velox_common_hyperloglog
velox_dwio_common_encryption
velox_dwio_common_exception
velox_exception
Expand Down
6 changes: 6 additions & 0 deletions velox/dwio/common/Statistics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ class ColumnStatistics {
numDistinct_ = count;
}

/// Returns true if there are no non-null values (value count is known to be
/// zero).
bool isAllNull() const {
return valueCount_.has_value() && valueCount_.value() == 0;
}

/**
* return string representation of this stats object
*/
Expand Down
Loading
Loading