Skip to content

build(cuda): Add CUDA_VERSION build arg to adapters dockerfile #16234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdice wants to merge 2 commits into from
Closed

build(cuda): Add CUDA_VERSION build arg to adapters dockerfile #16234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1564356
build(cuda): Add CUDA_VERSION build arg to adapters dockerfile
bdice Feb 4, 2026
81adc2d
fix(cuda): Pass CUDA_VERSION via env instead of arg to install_cuda
bdice Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/docker/centos-multi.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@

COPY scripts/setup-centos-adapters.sh /

ARG CUDA_VERSION
ENV CUDA_VERSION=${CUDA_VERSION:-12.9}
Copy link
Copy Markdown
Collaborator Author

@bdice bdice Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This environment variable is read by bash /setup-centos-adapters.sh install_cuda in the next step.


RUN bash /setup-centos-adapters.sh install_cuda && \
dnf clean all

Expand Down Expand Up @@ -161,7 +164,7 @@
PATH=/usr/lib/jvm/java-1.8.0-openjdk/bin:${PATH}

# thrift1 requires shared libraries copied from /deps to /usr/local.
ENV LD_LIBRARY_PATH="/usr/local/lib:/usr/local/lib64:$LD_LIBRARY_PATH"

Check warning on line 167 in scripts/docker/centos-multi.dockerfile

View workflow job for this annotation

GitHub Actions / Build ci Image on amd64

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 167 in scripts/docker/centos-multi.dockerfile

View workflow job for this annotation

GitHub Actions / Build ci Image on arm64

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

COPY --from=adapters-build /deps /usr/local

Expand Down
Loading