Skip to content

Revert "feat: Add rewrite for IN special form" #15649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kagamiori wants to merge 1 commit into from
Closed

Revert "feat: Add rewrite for IN special form" #15649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion velox/functions/prestosql/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ velox_add_library(
FindFirst.cpp
FromUtf8.cpp
InPredicate.cpp
InRewrite.cpp
JsonFunctions.cpp
Map.cpp
MapEntries.cpp
Expand Down
79 changes: 0 additions & 79 deletions velox/functions/prestosql/InRewrite.cpp
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions velox/functions/prestosql/InRewrite.h
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions velox/functions/prestosql/registration/GeneralFunctionsRegistration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "velox/functions/prestosql/Fail.h"
#include "velox/functions/prestosql/GreatestLeast.h"
#include "velox/functions/prestosql/InPredicate.h"
#include "velox/functions/prestosql/InRewrite.h"
#include "velox/functions/prestosql/Reduce.h"
#include "velox/functions/prestosql/types/IPAddressType.h"
#include "velox/functions/prestosql/types/TimestampWithTimeZoneType.h"
Expand Down Expand Up @@ -80,8 +79,6 @@ void registerAllSpecialFormGeneralFunctions() {
bool,
Generic<T1>,
Variadic<Generic<T1>>>({"in"});
InRewrite::registerRewrite();
Copy link
Copy Markdown
Collaborator

@pramodsatya pramodsatya Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kagamiori, could you please remove the registration of the rewrite and retain InRewrite.h/.cpp? Reference: #15549 (comment) .

Copy link
Copy Markdown
Contributor Author

@kagamiori kagamiori Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pramodsatya, sorry that I just saw your message, but this PR is already merged. Could you create another PR to add InRewrite.h/.cpp back? (By the way, we found that IN after rewrite can produce incorrect result, so it's probably safer for your use case too to fix this bug before continue using it.)

Copy link
Copy Markdown
Collaborator

@pramodsatya pramodsatya Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kagamiori, no worries, I reintroduced the IN-rewrite here: #15663, avoiding the rewrite for expressions of form NULL IN [a, b, ...] in order to respect the kNullAsIndeterminate null compare flag and fix the result change. Could you please take a look when you get a chance?


VELOX_REGISTER_VECTOR_FUNCTION(udf_concat_row, expression::kRowConstructor);
registerIsNullFunction("is_null");
}
Expand Down
1 change: 0 additions & 1 deletion velox/functions/prestosql/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ add_executable(
P4HyperLogLogCastTest.cpp
SetDigestCastTest.cpp
InPredicateTest.cpp
InRewriteTest.cpp
IntegerFunctionsTest.cpp
IPAddressCastTest.cpp
IPPrefixCastTest.cpp
Expand Down
118 changes: 0 additions & 118 deletions velox/functions/prestosql/tests/InRewriteTest.cpp
View file
Open in desktop

This file was deleted.