refactor: Change leafCallToSubfieldFilter API to return an optional pair#15555
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova:export-D87384500
Closed
refactor: Change leafCallToSubfieldFilter API to return an optional pair#15555mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom mbasmanova:export-D87384500
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova:export-D87384500
Conversation
Summary: ExprToSubfieldFilterParser::leafCallToSubfieldFilter used to return a pair of subfield and a filter using a combination or a return value and an output parameter. Now, the API returns an std::optional std::pair. Differential Revision: D87384500
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87384500. |
Yuhta
approved these changes
Nov 18, 2025
|
This pull request has been merged in ecddafb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: ExprToSubfieldFilterParser::leafCallToSubfieldFilter used to return a pair of subfield and a filter using a combination or a return value and an output parameter. Now, the API returns an std::optional std::pair.
Differential Revision: D87384500