feat: Add AND/OR aggregation feature to TableEvolutionFuzzer#15528
Closed
juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat: Add AND/OR aggregation feature to TableEvolutionFuzzer#15528juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@juwentus1234 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87204100. |
juwentus1234
added a commit
to juwentus1234/velox
that referenced
this pull request
Nov 18, 2025
…EvolutionFuzzer (facebookincubator#15528) Summary: Add support for bool_and, bool_or aggregation and bitwise_and_agg, bitwise_or_agg, bitwise_xor_agg functions in the TableEvolutionFuzzer's aggregation pushdown testing. ## Changes Extended the aggregation pushdown configuration generator to support boolean aggregation functions and bitwise aggregation functions in addition to the existing numeric aggregation functions: - Split `supportedAggs` into two separate lists: - `supportedNumericAggs`: {min, max} for numeric columns (INTEGER, BIGINT, REAL, DOUBLE, etc.) - `supportedBooleanAggs`: {bool_and, bool_or} for boolean columns - `supportedIntegerAggs`: {bitwise_and_agg, bitwise_or_agg, bitwise_xor_agg} for integer columns - Updated column collection logic to separately track numeric and boolean columns that are eligible for aggregation - Modified aggregation selection to independently try both numeric and boolean aggregations with 50% probability each, allowing for more diverse test coverage This change enables more comprehensive testing of aggregation pushdown functionality by including boolean aggregate functions, ensuring better coverage of different data types and aggregation scenarios. Differential Revision: D87204100
juwentus1234
force-pushed
the
export-D87204100
branch
from
51cdc94 to
6ab8230
Compare
…EvolutionFuzzer (facebookincubator#15528) Summary: Add support for bool_and, bool_or aggregation and bitwise_and_agg, bitwise_or_agg, bitwise_xor_agg functions in the TableEvolutionFuzzer's aggregation pushdown testing. ## Changes Extended the aggregation pushdown configuration generator to support boolean aggregation functions and bitwise aggregation functions in addition to the existing numeric aggregation functions: - Split `supportedAggs` into two separate lists: - `supportedNumericAggs`: {min, max} for numeric columns (INTEGER, BIGINT, REAL, DOUBLE, etc.) - `supportedBooleanAggs`: {bool_and, bool_or} for boolean columns - `supportedIntegerAggs`: {bitwise_and_agg, bitwise_or_agg, bitwise_xor_agg} for integer columns - Updated column collection logic to separately track numeric and boolean columns that are eligible for aggregation - Modified aggregation selection to independently try both numeric and boolean aggregations with 50% probability each, allowing for more diverse test coverage This change enables more comprehensive testing of aggregation pushdown functionality by including boolean aggregate functions, ensuring better coverage of different data types and aggregation scenarios. Reviewed By: Yuhta Differential Revision: D87204100
juwentus1234
force-pushed
the
export-D87204100
branch
from
6ab8230 to
4a34b15
Compare
|
This pull request has been merged in b26ce23. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for bool_and and bool_or aggregation functions in the TableEvolutionFuzzer's aggregation pushdown testing.
Changes
Extended the aggregation pushdown configuration generator to support boolean aggregation functions in addition to the existing numeric aggregation functions:
Split
supportedAggsinto two separate lists:supportedNumericAggs: {min, max} for numeric columns (INTEGER, BIGINT, REAL, DOUBLE, etc.)supportedBooleanAggs: {bool_and, bool_or} for boolean columnsUpdated column collection logic to separately track numeric and boolean columns that are eligible for aggregation
Modified aggregation selection to independently try both numeric and boolean aggregations with 50% probability each, allowing for more diverse test coverage
This change enables more comprehensive testing of aggregation pushdown functionality by including boolean aggregate functions, ensuring better coverage of different data types and aggregation scenarios.
Differential Revision: D87204100