fix: Correct dayOfWeek letter for SimpleDateTimeFormatter

[wForget]

In Velox, e was incorrectly used as the dayOfWeek letter in SimpleDateTimeFormatter.

velox/velox/functions/lib/DateTimeFormatter.cpp

Lines 2023 to 2025 in 974e77c

	case 'e':
	builder.appendDayOfWeek1Based(count);
	break;

This PR fixes this by using the letter u to be consistent with Java.
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/text/SimpleDateFormat.html

Closes #15516.

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	8d8edf9
🔍 Latest deploy log	https://app.netlify.com/projects/meta-velox/deploys/691d878ec7d166000830a4e4

[wForget]

@NEUpanning Could you please take a look?

[NEUpanning]

LGTM, relates to #10354.

[wForget]

@rui-mo @jinchengchenghh Could you please take a look?

[rui-mo]

@wForget Thanks for the fix. Does the letter differ across Java versions? Since this is a fix in "functions/lib", could it have any impact on Presto’s behavior?

[wForget]

@wForget Thanks for the fix. Does the letter differ across Java versions?

I checked java 8/17/21 and all of them use u to represent dayOfWeek.

Since this is a fix in "functions/lib", could it have any impact on Presto’s behavior?

It seems not, buildSimpleDateTimeFormatter is only used by spark.

[zml1206]

After it was merged, #15535 will rebase.

[rui-mo]

Created #15582 to track the workflow failure.

[meta-codesync]

@kagamiori has imported this pull request. If you are a Meta employee, you can view this in D87597881.

[meta-codesync]

@kagamiori merged this pull request in ffa685d.