Skip to content

fix(cudf): Add missed updates to LocalPartition and Aggregation #15368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

fix(cudf): Add missed updates to LocalPartition and Aggregation #15368

wants to merge 8 commits into from
+73 −17

Conversation

@karthikeyann
Copy link
Collaborator

@karthikeyann karthikeyann commented Nov 3, 2025 •
edited
Loading

This PR adds following changes

  • Adds flushVectorPool() method to CudfLocalPartition to release vectors after it is consumed.
  • Adds missed StreamingAggregation updates to ToCudf.cpp
  • Adds missed getBuildStream in CudfHashJoinProbe

@karthikeyann karthikeyann requested a review from devavret November 3, 2025 05:18
@netlify
Copy link

netlify bot commented Nov 3, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 9e75e84
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/690a47544602720008b449c4

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@karthikeyann karthikeyann changed the title fix: Add flushVectorPool in CudfLocalPartition fix(cudf): Add flushVectorPool in CudfLocalPartition Nov 3, 2025
@karthikeyann karthikeyann changed the title fix(cudf): Add flushVectorPool in CudfLocalPartition fix(cudf): Add missed updates to LocalPartition and Aggregation Nov 3, 2025
@karthikeyann karthikeyann added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D86219647.

@meta-codesync meta-codesync bot closed this in 2423fbe Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@kevinwilfong merged this pull request in 2423fbe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devavret devavret devavret approved these changes

@jinchengchenghh jinchengchenghh jinchengchenghh approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner

@mhaseeb123 mhaseeb123 Awaiting requested review from mhaseeb123 mhaseeb123 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karthikeyann @devavret @jinchengchenghh @facebook-github-bot