Skip to content

fix: Add exception handling for ParallelUnitLoader #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add exception handling for ParallelUnitLoader #15355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions velox/dwio/common/ParallelUnitLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ class ParallelUnitLoader : public UnitLoader {
NanosecondTimer timer{&unitLoadNanos};
futures_[unit].wait();
} catch (const std::exception& e) {
LOG(ERROR) << "Driver thread caught exception from I/O thread for unit "
<< unit << ": " << e.what();
VELOX_FAIL("Failed to load unit {}: {}", unit, e.what());
}
waitForUnitReadyNanos_ += unitLoadNanos;
Expand Down Expand Up @@ -138,8 +140,19 @@ class ParallelUnitLoader : public UnitLoader {
VELOX_CHECK_LT(unitIndex, loadUnits_.size(), "Unit index out of bounds");
VELOX_CHECK_NOT_NULL(ioExecutor_, "ParallelUnitLoader ioExecutor is null");

futures_[unitIndex] = folly::via(
ioExecutor_, [this, unitIndex]() { loadUnits_[unitIndex]->load(); });
futures_[unitIndex] = folly::via(ioExecutor_, [this, unitIndex]() {
try {
loadUnits_[unitIndex]->load();
} catch (const std::exception& e) {
LOG(ERROR) << "I/O thread crashed while loading unit " << unitIndex
<< ": " << e.what();
throw; // Re-throw to fail the future
} catch (...) {
LOG(ERROR) << "I/O thread crashed while loading unit " << unitIndex
<< " with unknown exception";
throw;
}
});
unitsLoaded_[unitIndex] = true;
}

Expand Down
Loading