fix: Use envelope serde in ST_Envelope #15349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@Sullivan-Patrick has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85973036. |
Sullivan-Patrick
force-pushed
the
export-D85973036
branch
from
bb26ccd to
c4a5977
Compare
Sullivan-Patrick
pushed a commit
to Sullivan-Patrick/velox
that referenced
this pull request
Nov 3, 2025
Summary: This led to a discrepency between java and C++ where java would happily build an envelope from an invalid polygon and C++ would fail. Reviewed By: jagill Differential Revision: D85973036
Sullivan-Patrick
pushed a commit
to Sullivan-Patrick/velox
that referenced
this pull request
Nov 3, 2025
Summary: This led to a discrepency between java and C++ where java would happily build an envelope from an invalid polygon and C++ would fail. Reviewed By: jagill Differential Revision: D85973036
Sullivan-Patrick
force-pushed
the
export-D85973036
branch
from
c4a5977 to
71b6356
Compare
kgpai
approved these changes
Nov 3, 2025
Summary: This led to a discrepency between java and C++ where java would happily build an envelope from an invalid polygon and C++ would fail. Reviewed By: kgpai, jagill Differential Revision: D85973036
Sullivan-Patrick
force-pushed
the
export-D85973036
branch
from
71b6356 to
c44e2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This led to a discrepency between java and C++ where java would happily build an envelope from an invalid polygon and C++ would fail.
Differential Revision: D85973036