Skip to content

fix(build): Add explicit dependency for fastfloat instead of implicit from folly #15322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MBkkt wants to merge 1 commit into from
Closed

fix(build): Add explicit dependency for fastfloat instead of implicit from folly #15322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMake/resolve_dependency_modules/folly/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
project(Folly)
cmake_minimum_required(VERSION 3.28)

velox_set_source(fastfloat)
velox_resolve_dependency(fastfloat CONFIG REQUIRED)
velox_set_source(FastFloat)
velox_resolve_dependency(FastFloat CONFIG REQUIRED)
Comment on lines +17 to +18
Copy link
Copy Markdown
Collaborator Author

@MBkkt MBkkt Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this it's impossible to use system fast float.
Because only FindFastFloat.cmake provided

Copy link
Copy Markdown
Collaborator

@jinchengchenghh jinchengchenghh Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/fastfloat.cmake#L26 name it to FASTFLOAT, which name should we use? I'm not familiar with the Velox build.

Copy link
Copy Markdown
Collaborator

@jinchengchenghh jinchengchenghh Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fastfloat.cmake will replace FindFastFloat.cmake

Copy link
Copy Markdown
Collaborator Author

@MBkkt MBkkt Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there're two cases, both checked in Velox CI:

  1. installed system fast-float, in such case FindFastFloat.cmake will be used
  2. from source code build fast-float, in such case fastfloat.cmake will be used, because velox_build_dependency is case insensitive.

https://github.com/facebookincubator/velox/blob/main/CMake/resolve_dependency_modules/fastfloat.cmake#L26 name it to FASTFLOAT,

This is expected, because for velox_resolve_dependency_url argument should be written in UPPER_CASE

Copy link
Copy Markdown
Collaborator

@assignUser assignUser Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Yes exactly, sorry for the late answer. Thanks for the change, I didn't realize we where using fastfloat transitively!


set(VELOX_FOLLY_BUILD_VERSION v2025.04.28.00)
set(
Expand Down
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ endif()
velox_set_source(simdjson)
velox_resolve_dependency(simdjson 3.13.0)

velox_set_source(FastFloat)
velox_resolve_dependency(FastFloat)

velox_set_source(folly)
velox_resolve_dependency(folly)

Expand Down
1 change: 1 addition & 0 deletions velox/functions/prestosql/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ velox_link_libraries(
velox_presto_types
velox_functions_util
Folly::folly
FastFloat::fast_float
Comment thread
jinchengchenghh marked this conversation as resolved.
Comment thread
majetideepak marked this conversation as resolved.
stemmer::stemmer
)

Expand Down
Loading