misc: Backout 'Support decimal as partition key type in Hive write and read' #15310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
kgpai
changed the title
Support decimal as partition key type in Hive write and read
kgpai
force-pushed
the
export-D85714403
branch
from
284c1e4 to
6845201
Compare
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Oct 29, 2025
…d read` (facebookincubator#15310) Summary: This change revert's facebookincubator#12910 , as per [issue 15309](facebookincubator#15309) . Differential Revision: D85714403
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Oct 29, 2025
…d read` (facebookincubator#15310) Summary: This change revert's facebookincubator#12910 , as per [issue 15309](facebookincubator#15309) . Differential Revision: D85714403
kgpai
force-pushed
the
export-D85714403
branch
from
6845201 to
3dddbe3
Compare
Yuhta
approved these changes
Oct 29, 2025
…d read` (facebookincubator#15310) Summary: This change revert's facebookincubator#12910 , as per [issue 15309](facebookincubator#15309) . Reviewed By: Yuhta Differential Revision: D85714403
kgpai
force-pushed
the
export-D85714403
branch
from
3dddbe3 to
fd325f4
Compare
Contributor
Author
|
@PingLiuPing I had to delete IcebergReadTest.mixedScenario from #14516 as DECIMAL's are not supported in as partition key type due to this revert. |
Collaborator
|
@kgpai Thanks for noticing. |
PingLiuPing
approved these changes
Oct 29, 2025
Collaborator
PingLiuPing
left a comment
PingLiuPing
left a comment
There was a problem hiding this comment.
Changes within IcebergReadTest looks good.
|
This pull request has been merged in 6529448. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This change revert's #12910 , as per issue 15309 .
Differential Revision: D85714403