build(ci): Run clang-tidy and add license header annotations #15284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
bot
added
the
CLA Signed
assignUser
force-pushed
the
run-clang-tidy-ci
branch
12 times, most recently
from
c9899f5 to
f13002c
Compare
assignUser
force-pushed
the
run-clang-tidy-ci
branch
from
20a99db to
aac2d99
Compare
assignUser
changed the title
use re instead of regex fix git ownership and build dir name fix fetch depth debug full checkout use proper merge base
assignUser
force-pushed
the
run-clang-tidy-ci
branch
from
aac2d99 to
6509eba
Compare
assignUser
commented
Nov 3, 2025
…manual stage. It will now diff against HEAD in pre-commit -> pre-commit using staged files.
…son found This might skipp running clang-tidy locally if the contributor hasn't setup correctly but this is imo much more acceptable (due to CI) than making peoples pre-commit fail spuriosly.
|
|
||
| - run: uv tool install clang-tidy==18.1.8 | ||
|
|
||
| - name: Configure Maximal Build |
Collaborator
There was a problem hiding this comment.
Why do we need to configure the build?
Collaborator
Author
There was a problem hiding this comment.
clang-tidy needs the compilation database ('compile_commands.json')
czentgr
reviewed
Nov 11, 2025
pedroerp
approved these changes
Nov 14, 2025
Contributor
pedroerp
left a comment
pedroerp
left a comment
There was a problem hiding this comment.
Accepting as @czentgr has reviewed it. Thanks @assignUser
pedroerp
added
the
ready-to-merge
czentgr
reviewed
Nov 21, 2025
| header_comment = "" | ||
|
|
||
| message(log_to, "Fix : " + filepath) | ||
| if os.environ.get("GITHUB_ACTIONS"): |
Collaborator
There was a problem hiding this comment.
I didn't realize this but this change causes build failures in PrestoC++. Namely, it re-generates the protocol in github and this adds the new error message to the output causing compile errors.
We do a regenerate in the CI to try and ensure java-cpp protocol compatibility.
We call "remove" explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might seems like overkill to use the adapters image but for clang-tidy to run it needs
compile-commands.json, so we need to run cmake, which needs the dependencies.I use
--line-filterto only output warnings on changed lines, other warnings would not show up as annotations anyway and take very long.The clang-tidy job only runs when there are changes to C++ files.
Closes: #15047
Closes: #15050