refactor: Remove usages of folly::StringPiece in Counters.h#15266
Closed
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Closed
refactor: Remove usages of folly::StringPiece in Counters.h#15266pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: Intermediate step while migrating legacy folly::StringPiece usages to std::string_view. Part of facebookincubator#14456 Differential Revision: D85371290
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
mbasmanova
approved these changes
Oct 23, 2025
bikramSingh91
approved these changes
Oct 23, 2025
|
This pull request has been merged in ca4cfb6. |
mhaseeb123
pushed a commit
to mhaseeb123/velox
that referenced
this pull request
Oct 27, 2025
…incubator#15266) Summary: Pull Request resolved: facebookincubator#15266 Intermediate step while migrating legacy folly::StringPiece usages to std::string_view. Part of facebookincubator#14456 Reviewed By: bikramSingh91, mbasmanova Differential Revision: D85371290 fbshipit-source-id: 8a37db72fdd5e03c094d9ee8e71f949477b3cc47
aditi-pandit
pushed a commit
to prestodb/presto
that referenced
this pull request
Nov 14, 2025
Velox has already removed folly::StringPiece in its Counters.h, this should be followed up in presto_cpp to reduce inconsistencies. X-link: facebookincubator/velox#15266 ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Intermediate step while migrating legacy folly::StringPiece usages
to std::string_view.
Part of #14456
Differential Revision: D85371290