Skip to content

refactor: Use re2::StringPiece for RE2::FullMatch() #15259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kou wants to merge 5 commits into from
Closed

refactor: Use re2::StringPiece for RE2::FullMatch() #15259

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca6e576
refactor: Use `absl::string_view` for `RE2::FullMatch()`
kou Oct 23, 2025
b84e687
Use re2::StringPiece for old RE2
kou Oct 23, 2025
48a4dac
Use newer RE2
kou Oct 24, 2025
c8827e8
Use absl::string_view
kou Oct 24, 2025
fc49726
Use re2::StringPiece
kou Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions velox/functions/prestosql/DateTimeFunctions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,15 +1939,18 @@ struct ParseDurationFunction {
re2::StringPiece valueStr;
re2::StringPiece unit;
if (!RE2::FullMatch(
std::string_view{amountUnit}, *durationRegex_, &valueStr, &unit)) {
re2::StringPiece(amountUnit.data(), amountUnit.size()),
*durationRegex_,
&valueStr,
&unit)) {
VELOX_USER_FAIL(
"Input duration is not a valid data duration string: {}", amountUnit);
}

double value{};
try {
size_t pos = 0;
// Create temporary string from StringPiece for stod
// Create temporary string from re2::StringPiece for stod
std::string valueString(valueStr.data(), valueStr.size());
value = std::stod(valueString, &pos);
if (pos != valueString.size()) {
Expand Down
Loading