fix: ST_CoordDim failing with wrong return type#15203
Closed
jkhaliqi wants to merge 1 commit intofacebookincubator:mainfrom
Closed
fix: ST_CoordDim failing with wrong return type#15203jkhaliqi wants to merge 1 commit intofacebookincubator:mainfrom
jkhaliqi wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
|
Interesting. Presto docs have it returning bigint (which is also different than integer): https://prestodb.io/docs/current/functions/geospatial.html#ST_CoordDim-Geometry-bigint Let me check the code... |
Contributor
|
The documentation is wrong, the Presto code has return type tinyint. I'll approve this but let's make sure the CI passes. |
jagill
approved these changes
Oct 17, 2025
jkhaliqi
force-pushed
the
st_coordDim_fix
branch
from
8440579 to
8cf1f42
Compare
Collaborator
Author
|
@jagill sounds good: posted a PR for presto documentation update as well : prestodb/presto#26355 |
jagill
added
the
ready-to-merge
mhaseeb123
pushed a commit
to mhaseeb123/velox
that referenced
this pull request
Oct 27, 2025
) Summary: ST_CoordDim return type should be tinyint based on : prestodb/presto#26344 Pull Request resolved: facebookincubator#15203 Reviewed By: bikramSingh91 Differential Revision: D85060868 Pulled By: pedroerp fbshipit-source-id: f8d61d597dc2dde359b133d0a4a605b93c27cf4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ST_CoordDim return type should be tinyint based on : prestodb/presto#26344