fix: Reenable intermediate/final type validation for aggregate functions #14934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In facebookincubator#13505 the validation was disabled, because regr_* functions in Presto and Velox had different signatures. The signature in Velox is more efficient, so I landed the fix on Presto side: prestodb/presto#25748 They're included into v0.295-edge13 presto release. Differential Revision: D82904840
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Contributor
|
@kletkavrubashku has exported this pull request. If you are a Meta employee, you can view the originating diff in D82904840. |
xiaoxmeng
approved these changes
Sep 23, 2025
Contributor
|
This pull request has been merged in 07ae1e8. |
zhztheplayer
added a commit
to IBM/velox
that referenced
this pull request
Sep 24, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 24, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 24, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 25, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 26, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Sep 29, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Oct 1, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 644) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 7593dc3
beliefer
pushed a commit
to beliefer/velox
that referenced
this pull request
Nov 3, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 3, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 3, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 3, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
Enochack
pushed a commit
to Enochack/velox
that referenced
this pull request
Nov 4, 2025
jinchengchenghh
pushed a commit
to jinchengchenghh/velox
that referenced
this pull request
Nov 4, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 4, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 5, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 5, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 5, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
zhouyuan
pushed a commit
to oap-project/velox
that referenced
this pull request
Nov 5, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 5, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 6, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to oap-project/velox
that referenced
this pull request
Nov 6, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 6, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 6, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 6, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 6, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to oap-project/velox
that referenced
this pull request
Nov 7, 2025
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 7, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 7, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 7, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 7, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 7, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
prestodb-ci
pushed a commit
to IBM/velox
that referenced
this pull request
Nov 8, 2025
And reverts facebookincubator#14934 Alchemy-item: (ID = 679) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 830028e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #13505 the validation was disabled, because regr_* functions in Presto and Velox had different signatures.
The signature in Velox is more efficient, so I landed the fix on Presto side:
prestodb/presto#25748
They're included into v0.295-edge13 presto release.
Differential Revision: D82904840