build(ci): Always run pre-commit on all files#14506
Closed
assignUser wants to merge 2 commits intofacebookincubator:mainfrom
Closed
build(ci): Always run pre-commit on all files#14506assignUser wants to merge 2 commits intofacebookincubator:mainfrom
assignUser wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
bot
added
the
CLA Signed
kgpai
approved these changes
Aug 18, 2025
kgpai
added
the
ready-to-merge
czentgr
approved these changes
Aug 19, 2025
Collaborator
czentgr
left a comment
czentgr
left a comment
There was a problem hiding this comment.
Thanks, that is much simpler.
6 tasks
peterenescu
approved these changes
Aug 25, 2025
Collaborator
|
@assignUser Please resolve the conflict. |
assignUser
force-pushed
the
make-pre-commit-strict
branch
from
61d7ef0 to
cc94e4f
Compare
Collaborator
Author
|
Done |
Contributor
|
@peterenescu has imported this pull request. If you are a Meta employee, you can view this in D81141453. |
Contributor
|
@peterenescu merged this pull request in 695e476. |
wypb
pushed a commit
to wypb/velox
that referenced
this pull request
Sep 3, 2025
Summary: Without our special check on changed files only we can simplify the workflow a lot and use the official action that handles caching. Fixes facebookincubator#14474 Pull Request resolved: facebookincubator#14506 Reviewed By: mbasmanova Differential Revision: D81141453 Pulled By: peterenescu fbshipit-source-id: 406df368689e4f336477088708e5eaa5834f9f57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without our special check on changed files only we can simplify the workflow a lot and use the official action that handles caching.
Fixes #14474