refactor: Use TypeKindName helpers#14337
Closed
hotcodemacha wants to merge 1 commit intofacebookincubator:mainfrom
Closed
refactor: Use TypeKindName helpers#14337hotcodemacha wants to merge 1 commit intofacebookincubator:mainfrom
hotcodemacha wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
hotcodemacha
requested review from
bdice,
devavret,
karthikeyann,
majetideepak and
mhaseeb123
as code owners
mbasmanova
added
the
ready-to-merge
mbasmanova
changed the title
hotcodemacha
force-pushed
the
ashu/14096
branch
from
d5ba1cc to
a14b0f0
Compare
Contributor
Author
|
@mbasmanova - Can you please help in triggering the workflows. I have updated the commit for with clang-format |
Contributor
Contributor
|
@hotcodemacha Can you fix the import issues |
kgpai
removed
the
ready-to-merge
Contributor
|
This took some internal refactoring. Some about the delay merging this. |
Closed
mhaseeb123
pushed a commit
to mhaseeb123/velox
that referenced
this pull request
Oct 27, 2025
Summary: fixes facebookincubator#14096 Removed legacy type-conversion helpers in Type.h, consolidating enum name translation under TypeKindName for a single source of truth Updated variant serialization to resolve type names and kinds through TypeKindName instead of deprecated mapping utilities Revised error handling and validation, such as subscript index checks, to use TypeKindName::toName across the codebase Pull Request resolved: facebookincubator#14337 Reviewed By: peterenescu, jagill Differential Revision: D79726130 Pulled By: pedroerp fbshipit-source-id: 334d538fff5ada96bd31b32e7e37e9056dc806ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14096
Removed legacy type-conversion helpers in Type.h, consolidating enum name translation under TypeKindName for a single source of truth
Updated variant serialization to resolve type names and kinds through TypeKindName instead of deprecated mapping utilities
Revised error handling and validation, such as subscript index checks, to use TypeKindName::toName across the codebase