Skip to content

feat: Add squared Euclidean distance (l2_squared) as a similarity function#13866

Closed
zhichenxu-meta wants to merge 1 commit intofacebookincubator:mainfrom
zhichenxu-meta:export-D77190483
Closed

feat: Add squared Euclidean distance (l2_squared) as a similarity function#13866
zhichenxu-meta wants to merge 1 commit intofacebookincubator:mainfrom
zhichenxu-meta:export-D77190483

Conversation

@zhichenxu-meta
Copy link
Copy Markdown
Contributor

@zhichenxu-meta zhichenxu-meta commented Jun 24, 2025

Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 24, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jun 24, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 24, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c2f5eb0
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/685eb0ce911a1e00081734ec

@zhichenxu-meta zhichenxu-meta marked this pull request as draft June 24, 2025 16:18
@zhichenxu-meta zhichenxu-meta changed the title Add l2_squared to cpp Feat: Add squared Euclidean distance (l2_squared) as an additional similarity function Jun 24, 2025
@zhichenxu-meta zhichenxu-meta changed the title Feat: Add squared Euclidean distance (l2_squared) as an additional similarity function Feat: Add squared Euclidean distance (l2_squared) as an additional similarity function. Jun 24, 2025
@zhichenxu-meta zhichenxu-meta changed the title Feat: Add squared Euclidean distance (l2_squared) as an additional similarity function. Feat: Add squared Euclidean distance (l2_squared) as a similarity function Jun 24, 2025
@zhichenxu-meta zhichenxu-meta changed the title Feat: Add squared Euclidean distance (l2_squared) as a similarity function feat: Add squared Euclidean distance (l2_squared) as a similarity function Jun 24, 2025
@zhichenxu-meta zhichenxu-meta marked this pull request as ready for review June 24, 2025 16:57
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 24, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

amitkdutta
amitkdutta approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhichenxu-meta

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

zacw7
zacw7 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zacw7 zacw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks for implementing the function. Can we add an entry to the doc somewhere like: https://github.com/facebookincubator/velox/blob/main/velox/docs/functions/presto/math.rst ?

velox/functions/prestosql/tests/DistanceFunctionsTest.cpp Outdated
Copy link
Copy Markdown
Contributor

@zacw7 zacw7 Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we name the test as l2SquaredFunctionFloatArray to keep the naming convention consistent?

amitkdutta
amitkdutta requested changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhichenxu-meta As @zacw7 mentioned, lets add documentation about function

@zhichenxu-meta
Copy link
Copy Markdown
Contributor Author

zhichenxu-meta commented Jun 27, 2025

@zhichenxu-meta As @zacw7 mentioned, lets add documentation about function

Thanks @zacw7 and @amitkdutta Added function documentation and sorry that missed that.

@zhichenxu-meta @facebook-github-bot
Add l2_squared to cpp (facebookincubator#13866)
c2f5eb0 
Summary: Pull Request resolved: facebookincubator#13866

Differential Revision: D77190483
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D77190483

zacw7
zacw7 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zacw7 zacw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks for adding the detailed documentation.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request has been merged in 6c819d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacw7 zacw7 zacw7 approved these changes

@amitkdutta amitkdutta Awaiting requested review from amitkdutta

Assignees

@amitkdutta amitkdutta

@xiaoxmeng xiaoxmeng

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhichenxu-meta @facebook-github-bot @zacw7 @amitkdutta @xiaoxmeng