refactor: Abstract the processInputRow loop in TopNRowNumber#13265
Closed
aditi-pandit wants to merge 1 commit intomainfrom
Closed
refactor: Abstract the processInputRow loop in TopNRowNumber#13265aditi-pandit wants to merge 1 commit intomainfrom
aditi-pandit wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
rui-mo
approved these changes
Jun 6, 2025
Collaborator
|
@xiaoxmeng Would you like to review this refactor? Thanks! |
aditi-pandit
force-pushed
the
process_input_row_loop
branch
2 times, most recently
from
4836840 to
478bf32
Compare
majetideepak
approved these changes
Jun 17, 2025
Collaborator
|
@xiaoxmeng can you please help review this? |
xiaoxmeng
approved these changes
Jun 18, 2025
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@aditi-pandit LGTM. Thanks!
xiaoxmeng
added
the
ready-to-merge
Contributor
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aditi-pandit
force-pushed
the
process_input_row_loop
branch
from
478bf32 to
39f40a4
Compare
Contributor
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@kevinwilfong merged this pull request in 6be662b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11554