fix: Fix the right join result mismatch issue #13065
Closed
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Apr 18, 2025
JkSelf
force-pushed
the
right-join-fix
branch
2 times, most recently
from
db58ade to
ad3d4f2
Compare
xiaoxmeng
reviewed
Apr 22, 2025
Collaborator
Author
|
@xiaoxmeng Resolved all your comments. Please help to review again. Thanks. |
Contributor
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kevinwilfong
approved these changes
Apr 22, 2025
Contributor
kevinwilfong
left a comment
kevinwilfong
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Contributor
|
@xiaoxmeng merged this pull request in 8285db4. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a right join operation using above data, if we directly set rightRowIndex_ to 0 here, it will result in all final outcomes being empty in left side. This is because during the comparison process, the first value of the right input is null, leading to a comparison result of -1 consistently. Consequently, all the left-side data will be fully traversed, and the input will be set to null columns, resulting in the final output returning only the right-side columns, with all left-side columns set to null. And this PR addresses the above issue by skipping the null row index prior to comparing the results.