test(fuzzer): Skip MapKeysByTopNValues test#12447
Closed
duxiao1212 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
test(fuzzer): Skip MapKeysByTopNValues test#12447duxiao1212 wants to merge 1 commit intofacebookincubator:mainfrom
duxiao1212 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
duxiao1212
changed the title
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 25, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
6be9032 to
c0ce983
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
changed the title
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 26, 2025
Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
c0ce983 to
8db4c8b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 26, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
8db4c8b to
9cfddb3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 26, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
9cfddb3 to
c00b90d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
duxiao1212
force-pushed
the
export-D70198160
branch
from
c00b90d to
68b549c
Compare
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 26, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Feb 26, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
68b549c to
5f23b8a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70198160 |
duxiao1212
changed the title
duxiao1212
changed the title
yuandagits
approved these changes
Feb 26, 2025
…2447) Summary: The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public. The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list. Reviewed By: kgpai, yuandagits, HeidiHan0000 Differential Revision: D70198160
duxiao1212
force-pushed
the
export-D70198160
branch
from
5f23b8a to
d8d50bd
Compare
Contributor
|
This pull request has been merged in f5c25ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The fuzzer test for map_keys_by_top_n_values should be skipped until the presto array comparison null catch patch is fully released to the public.
The only failure scenario occurs when the input value is an array with a null element, which is low risk and has already been fixed in this prestodb/presto#24570. Once the patch is fully rolled out, we can remove the method from the skip list.
Reviewed By: HeidiHan0000
Differential Revision: D70198160