[WIP] MacOS CMake compatibility for dynamic functions#12111
Closed
mohsaka wants to merge 4 commits intofacebookincubator:mainfrom
Closed
[WIP] MacOS CMake compatibility for dynamic functions#12111mohsaka wants to merge 4 commits intofacebookincubator:mainfrom
mohsaka wants to merge 4 commits intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Collaborator
|
@mohsaka I made this a draft based on the PR description. |
mohsaka
force-pushed
the
michael_test
branch
2 times, most recently
from
bbf091b to
c1210c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently being used to make sure we can compile on MacOS and Linux.
This will eventually be merged into this PR/branch
#11439