Skip to content

feat(fuzzer): Add TopNRowNumberFuzzer #12103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aditi-pandit wants to merge 1 commit into from
Closed

feat(fuzzer): Add TopNRowNumberFuzzer #12103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions velox/exec/fuzzer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ target_link_libraries(
velox_type_parser
Folly::folly
velox_hive_connector
velox_dwio_dwrf_reader
velox_dwio_dwrf_writer
velox_dwio_catalog_fbhive
velox_dwio_faulty_file_sink)
Expand Down Expand Up @@ -79,22 +78,39 @@ target_link_libraries(
velox_aggregation_fuzzer_base
velox_temp_path)

add_library(velox_row_number_fuzzer_base_lib RowNumberFuzzerBase.cpp)

target_link_libraries(
velox_row_number_fuzzer_base_lib
velox_dwio_dwrf_reader
velox_fuzzer_util
velox_vector_fuzzer
velox_exec_test_lib)

add_library(velox_row_number_fuzzer_lib RowNumberFuzzer.cpp)

target_link_libraries(
velox_row_number_fuzzer_lib velox_row_number_fuzzer_base_lib velox_type
velox_expression_test_utility)

# RowNumber Fuzzer.
add_executable(velox_row_number_fuzzer RowNumberFuzzerRunner.cpp)

target_link_libraries(
velox_row_number_fuzzer velox_row_number_fuzzer_lib)

add_library(velox_topn_row_number_fuzzer_lib TopNRowNumberFuzzer.cpp)

target_link_libraries(
velox_row_number_fuzzer_lib
velox_fuzzer_util
velox_type
velox_vector_fuzzer
velox_exec_test_lib
velox_topn_row_number_fuzzer_lib velox_row_number_fuzzer_base_lib velox_type
velox_expression_test_utility)

# TopNRowNumber Fuzzer.
add_executable(velox_topn_row_number_fuzzer TopNRowNumberFuzzerRunner.cpp)

target_link_libraries(
velox_topn_row_number_fuzzer velox_topn_row_number_fuzzer_lib)

add_library(velox_join_fuzzer JoinFuzzer.cpp)

target_link_libraries(
Expand Down
56 changes: 56 additions & 0 deletions velox/exec/fuzzer/DuckQueryRunner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ std::optional<std::string> DuckQueryRunner::toSql(
return toSql(rowNumberNode);
}

if (const auto topNRowNumberNode =
std::dynamic_pointer_cast<const core::TopNRowNumberNode>(plan)) {
return toSql(topNRowNumberNode);
}

if (const auto joinNode =
std::dynamic_pointer_cast<const core::HashJoinNode>(plan)) {
return toSql(joinNode);
Expand Down Expand Up @@ -377,4 +382,55 @@ std::optional<std::string> DuckQueryRunner::toSql(

return sql.str();
}

std::optional<std::string> DuckQueryRunner::toSql(
const std::shared_ptr<const core::TopNRowNumberNode>& topNRowNumberNode) {
std::stringstream sql;
sql << "SELECT * FROM (SELECT ";

const auto& inputType = topNRowNumberNode->sources()[0]->outputType();
for (auto i = 0; i < inputType->size(); ++i) {
appendComma(i, sql);
sql << inputType->nameOf(i);
}

sql << ", row_number() OVER (";

const auto& partitionKeys = topNRowNumberNode->partitionKeys();
if (!partitionKeys.empty()) {
sql << "partition by ";
for (auto i = 0; i < partitionKeys.size(); ++i) {
appendComma(i, sql);
sql << partitionKeys[i]->name();
}
}

const auto& sortingKeys = topNRowNumberNode->sortingKeys();
const auto& sortingOrders = topNRowNumberNode->sortingOrders();

if (!sortingKeys.empty()) {
sql << " ORDER BY ";
for (auto j = 0; j < sortingKeys.size(); ++j) {
appendComma(j, sql);
sql << sortingKeys[j]->name() << " " << sortingOrders[j].toString();
}
}

std::string rowNumberColumnName = topNRowNumberNode->generateRowNumber()
? topNRowNumberNode->outputType()->nameOf(
topNRowNumberNode->outputType()->children().size() - 1)
: "row_number";

// TopNRowNumberNode should have a single source.
std::optional<std::string> source = toSql(topNRowNumberNode->sources()[0]);
if (!source) {
return std::nullopt;
}
sql << ") as " << rowNumberColumnName << " FROM " << *source << ") ";
sql << " where " << rowNumberColumnName
<< " <= " << topNRowNumberNode->limit();

return sql.str();
}

} // namespace facebook::velox::exec::test
3 changes: 3 additions & 0 deletions velox/exec/fuzzer/DuckQueryRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ class DuckQueryRunner : public ReferenceQueryRunner {
std::optional<std::string> toSql(
const std::shared_ptr<const core::RowNumberNode>& rowNumberNode);

std::optional<std::string> toSql(
const std::shared_ptr<const core::TopNRowNumberNode>& topNRowNumberNode);

std::unordered_set<std::string> aggregateFunctionNames_;
};

Expand Down
59 changes: 59 additions & 0 deletions velox/exec/fuzzer/PrestoQueryRunner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ std::optional<std::string> PrestoQueryRunner::toSql(
return toSql(rowNumberNode);
}

if (const auto topNRowNumberNode =
std::dynamic_pointer_cast<const core::TopNRowNumberNode>(plan)) {
return toSql(topNRowNumberNode);
}

if (auto tableWriteNode =
std::dynamic_pointer_cast<const core::TableWriteNode>(plan)) {
return toSql(tableWriteNode);
Expand Down Expand Up @@ -497,6 +502,60 @@ std::optional<std::string> PrestoQueryRunner::toSql(
return sql.str();
}

std::optional<std::string> PrestoQueryRunner::toSql(
const std::shared_ptr<const core::TopNRowNumberNode>& topNRowNumberNode) {
if (!isSupportedDwrfType(topNRowNumberNode->sources()[0]->outputType())) {
return std::nullopt;
}

std::stringstream sql;
sql << "SELECT * FROM (SELECT ";

const auto& inputType = topNRowNumberNode->sources()[0]->outputType();
for (auto i = 0; i < inputType->size(); ++i) {
appendComma(i, sql);
sql << inputType->nameOf(i);
}

sql << ", row_number() OVER (";

const auto& partitionKeys = topNRowNumberNode->partitionKeys();
if (!partitionKeys.empty()) {
sql << "partition by ";
for (auto i = 0; i < partitionKeys.size(); ++i) {
appendComma(i, sql);
sql << partitionKeys[i]->name();
}
}

const auto& sortingKeys = topNRowNumberNode->sortingKeys();
const auto& sortingOrders = topNRowNumberNode->sortingOrders();

if (!sortingKeys.empty()) {
sql << " ORDER BY ";
for (auto j = 0; j < sortingKeys.size(); ++j) {
appendComma(j, sql);
sql << sortingKeys[j]->name() << " " << sortingOrders[j].toString();
}
}

std::string rowNumberColumnName = topNRowNumberNode->generateRowNumber()
? topNRowNumberNode->outputType()->nameOf(
topNRowNumberNode->outputType()->children().size() - 1)
: "row_number";

// TopNRowNumberNode should have a single source.
std::optional<std::string> source = toSql(topNRowNumberNode->sources()[0]);
if (!source) {
return std::nullopt;
}
sql << ") as " << rowNumberColumnName << " FROM " << *source << ") ";
sql << " where " << rowNumberColumnName
<< " <= " << topNRowNumberNode->limit();

return sql.str();
}

std::optional<std::string> PrestoQueryRunner::toSql(
const std::shared_ptr<const core::TableWriteNode>& tableWriteNode) {
auto insertTableHandle =
Expand Down
3 changes: 3 additions & 0 deletions velox/exec/fuzzer/PrestoQueryRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ class PrestoQueryRunner : public velox::exec::test::ReferenceQueryRunner {
std::optional<std::string> toSql(
const std::shared_ptr<const velox::core::RowNumberNode>& rowNumberNode);

std::optional<std::string> toSql(
const std::shared_ptr<const core::TopNRowNumberNode>& rowNumberNode);

std::optional<std::string> toSql(
const std::shared_ptr<const core::TableWriteNode>& tableWriteNode);

Expand Down
Loading