fix: Fix the MergeSource data lost issue #11772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Collaborator
Author
|
@pedroerp Can you help to review this PR? Thanks. |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Apr 23, 2025
| struct State { | ||
| bool atEnd = false; | ||
| RowVectorPtr data; | ||
| std::queue<RowVectorPtr> dataQueue; |
Contributor
There was a problem hiding this comment.
in which case, we have more than one output?
Collaborator
Author
There was a problem hiding this comment.
When executing a 1GB TPC-H Query 21 using multiple executors and multiple cores, the issue will arise.
Collaborator
Author
|
Closing this PR because the current code does not have any data loss issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the TPCH Q21 query, we found that performing a left semi join followed by a left anti join in the same stage resulted in incorrect results. Upon investigation, we discovered that MergeSource was losing data in such complex join scenarios. This PR addresses the issue by placing the data from MergeSource into a queue, ensuring that the next method call only ends when the queue is empty.