Skip to content

Add support for Arrow Flight package installation #11588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rijin-N wants to merge 1 commit into from
Closed

Add support for Arrow Flight package installation #11588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions scripts/setup-adapters.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,32 +61,6 @@ function install_gcs-sdk-cpp {
# Install gcs dependencies
# https://github.com/googleapis/google-cloud-cpp/blob/main/doc/packaging.md#required-libraries

# abseil-cpp
Copy link
Collaborator

@czentgr czentgr Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also called for macOS - for development using the GCS connector. So this can't be removed because it is also a dependency for that.

github_checkout abseil/abseil-cpp 20240116.2 --depth 1
cmake_install \
-DABSL_BUILD_TESTING=OFF \
-DCMAKE_CXX_STANDARD=17 \
-DABSL_PROPAGATE_CXX_STD=ON \
-DABSL_ENABLE_INSTALL=ON

# protobuf
github_checkout protocolbuffers/protobuf v21.8 --depth 1
cmake_install \
-Dprotobuf_BUILD_TESTS=OFF \
-Dprotobuf_ABSL_PROVIDER=package

# grpc
github_checkout grpc/grpc v1.48.1 --depth 1
cmake_install \
-DgRPC_BUILD_TESTS=OFF \
-DgRPC_ABSL_PROVIDER=package \
-DgRPC_ZLIB_PROVIDER=package \
-DgRPC_CARES_PROVIDER=package \
-DgRPC_RE2_PROVIDER=package \
-DgRPC_SSL_PROVIDER=package \
-DgRPC_PROTOBUF_PROVIDER=package \
-DgRPC_INSTALL=ON

# crc32
github_checkout google/crc32c 1.1.2 --depth 1
cmake_install \
Expand Down Expand Up @@ -180,13 +154,13 @@ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
if [[ "$LINUX_DISTRIBUTION" == "ubuntu" || "$LINUX_DISTRIBUTION" == "debian" ]]; then
apt install -y --no-install-recommends libxml2-dev libgsasl7-dev uuid-dev
# Dependencies of GCS, probably a workaround until the docker image is rebuilt
apt install -y --no-install-recommends libc-ares-dev libcurl4-openssl-dev
apt install -y --no-install-recommends libcurl4-openssl-dev
# Dependencies of Azure Storage Blob cpp
apt install -y openssl
else # Assume Fedora/CentOS
dnf -y install libxml2-devel libgsasl-devel libuuid-devel krb5-devel
# Dependencies of GCS, probably a workaround until the docker image is rebuilt
dnf -y install npm curl-devel c-ares-devel
dnf -y install npm curl-devel
# Dependencies of Azure Storage Blob Cpp
dnf -y install perl-IPC-Cmd
dnf -y install openssl
Expand Down
40 changes: 38 additions & 2 deletions scripts/setup-centos9.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export CXXFLAGS=$(get_cxx_flags) # Used by boost.
export CFLAGS=${CXXFLAGS//"-std=c++17"/} # Used by LZO.
CMAKE_BUILD_TYPE="${BUILD_TYPE:-Release}"
BUILD_DUCKDB="${BUILD_DUCKDB:-true}"
BUILD_ARROW_FLIGHT="${BUILD_ARROW_FLIGHT:-false}"
USE_CLANG="${USE_CLANG:-false}"
export INSTALL_PREFIX=${INSTALL_PREFIX:-"/usr/local"}
DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)/deps-download}
Expand Down Expand Up @@ -75,7 +76,7 @@ function install_velox_deps_from_dnf {
dnf_install libevent-devel \
openssl-devel re2-devel libzstd-devel lz4-devel double-conversion-devel \
libdwarf-devel elfutils-libelf-devel curl-devel libicu-devel bison flex \
libsodium-devel zlib-devel
libsodium-devel zlib-devel c-ares-devel

# install sphinx for doc gen
pip install sphinx sphinx-tabs breathe sphinx_rtd_theme
Expand Down Expand Up @@ -142,7 +143,8 @@ function install_protobuf {
./configure CXXFLAGS="-fPIC" --prefix=${INSTALL_PREFIX}
make "-j${NPROC}"
make install
ldconfig
ldconfig -v 2>/dev/null | grep "${INSTALL_PREFIX}/lib" || \
echo "${INSTALL_PREFIX}/lib" > /etc/ld.so.conf.d/local-libraries.conf && ldconfig
)
}

Expand Down Expand Up @@ -190,7 +192,38 @@ function install_stemmer {
)
}

function install_abseil {
# abseil-cpp
github_checkout abseil/abseil-cpp 20240116.2 --depth 1
cmake_install \
-DABSL_BUILD_TESTING=OFF \
-DCMAKE_CXX_STANDARD=17 \
-DABSL_PROPAGATE_CXX_STD=ON \
-DABSL_ENABLE_INSTALL=ON
}

function install_grpc {
# grpc
github_checkout grpc/grpc v1.48.1 --depth 1
cmake_install \
-DgRPC_BUILD_TESTS=OFF \
-DgRPC_ABSL_PROVIDER=package \
-DgRPC_ZLIB_PROVIDER=package \
-DgRPC_CARES_PROVIDER=package \
-DgRPC_RE2_PROVIDER=package \
-DgRPC_SSL_PROVIDER=package \
-DgRPC_PROTOBUF_PROVIDER=package \
-DgRPC_INSTALL=ON
}

function install_arrow {
if $BUILD_ARROW_FLIGHT; then
run_and_time install_grpc
ARROW_FLIGHT=ON
else
ARROW_FLIGHT=OFF
fi

wget_and_untar https://archive.apache.org/dist/arrow/arrow-${ARROW_VERSION}/apache-arrow-${ARROW_VERSION}.tar.gz arrow
cmake_install_dir arrow/cpp \
-DARROW_PARQUET=OFF \
Expand All @@ -204,6 +237,8 @@ function install_arrow {
-DARROW_RUNTIME_SIMD_LEVEL=NONE \
-DARROW_WITH_UTF8PROC=OFF \
-DARROW_TESTING=ON \
-DARROW_FLIGHT=${ARROW_FLIGHT} \
-DARROW_BUILD_BENCHMARKS=${ARROW_FLIGHT} \
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
-DCMAKE_BUILD_TYPE=Release \
-DARROW_BUILD_STATIC=ON \
Expand Down Expand Up @@ -241,6 +276,7 @@ function install_velox_deps {
run_and_time install_fbthrift
run_and_time install_duckdb
run_and_time install_stemmer
run_and_time install_abseil
Copy link
Collaborator

@czentgr czentgr Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are not direct dependencies and should be called from install_arrow to indicate these are only needed by Arrow - and only if BUILD_ARROW_FLIGHT was turned on.

Copy link
Author

@Rijin-N Rijin-N Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install_grpc function has been moved inside the install_arrow function. Other functions were not moved, as they are also required for the GCS connector.

run_and_time install_arrow
}

Expand Down
41 changes: 39 additions & 2 deletions scripts/setup-ubuntu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ COMPILER_FLAGS=$(get_cxx_flags)
export COMPILER_FLAGS
NPROC=$(getconf _NPROCESSORS_ONLN)
BUILD_DUCKDB="${BUILD_DUCKDB:-true}"
BUILD_ARROW_FLIGHT="${BUILD_ARROW_FLIGHT:-false}"
export CMAKE_BUILD_TYPE=Release
SUDO="${SUDO:-"sudo --preserve-env"}"
USE_CLANG="${USE_CLANG:-false}"
Expand Down Expand Up @@ -162,8 +163,10 @@ function install_protobuf {
cd ${DEPENDENCY_DIR}/protobuf
./configure CXXFLAGS="-fPIC" --prefix=${INSTALL_PREFIX}
make "-j${NPROC}"
make install
ldconfig
${SUDO} make install
${SUDO} ldconfig -v 2>/dev/null | grep "${INSTALL_PREFIX}/lib" || \
echo "${INSTALL_PREFIX}/lib" | ${SUDO} tee /etc/ld.so.conf.d/local-libraries.conf > /dev/null \
&& ${SUDO} ldconfig
)
}

Expand Down Expand Up @@ -229,7 +232,38 @@ function install_stemmer {
)
}

function install_abseil {
# abseil-cpp
github_checkout abseil/abseil-cpp 20240116.2 --depth 1
cmake_install \
-DABSL_BUILD_TESTING=OFF \
-DCMAKE_CXX_STANDARD=17 \
-DABSL_PROPAGATE_CXX_STD=ON \
-DABSL_ENABLE_INSTALL=ON
}

function install_grpc {
# grpc
github_checkout grpc/grpc v1.48.1 --depth 1
cmake_install \
-DgRPC_BUILD_TESTS=OFF \
-DgRPC_ABSL_PROVIDER=package \
-DgRPC_ZLIB_PROVIDER=package \
-DgRPC_CARES_PROVIDER=package \
-DgRPC_RE2_PROVIDER=package \
-DgRPC_SSL_PROVIDER=package \
-DgRPC_PROTOBUF_PROVIDER=package \
-DgRPC_INSTALL=ON
}

function install_arrow {
if $BUILD_ARROW_FLIGHT; then
run_and_time install_grpc
ARROW_FLIGHT=ON
else
ARROW_FLIGHT=OFF
fi

wget_and_untar https://archive.apache.org/dist/arrow/arrow-${ARROW_VERSION}/apache-arrow-${ARROW_VERSION}.tar.gz arrow
cmake_install_dir arrow/cpp \
-DARROW_PARQUET=OFF \
Expand All @@ -243,6 +277,8 @@ function install_arrow {
-DARROW_RUNTIME_SIMD_LEVEL=NONE \
-DARROW_WITH_UTF8PROC=OFF \
-DARROW_TESTING=ON \
-DARROW_FLIGHT=${ARROW_FLIGHT} \
-DARROW_BUILD_BENCHMARKS=${ARROW_FLIGHT} \
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
-DCMAKE_BUILD_TYPE=Release \
-DARROW_BUILD_STATIC=ON \
Expand Down Expand Up @@ -281,6 +317,7 @@ function install_velox_deps {
run_and_time install_conda
run_and_time install_duckdb
run_and_time install_stemmer
run_and_time install_abseil
run_and_time install_arrow
}

Expand Down