-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: Add AsyncDataCache and SSD cache documentation #11429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| ===================================== | ||
| AsyncDataCache (In Memory Data Cache) | ||
| ===================================== | ||
|
|
||
| Background | ||
| ---------- | ||
| Velox provides a transparent data cache (AsyncDataCache) to accelerate table scans operators through hot data reuse and prefetch algorithms. | ||
| This data cache is integrated with the memory system to achieve dynamic memory sharing between the data cache and query memory. | ||
| When a query fails to allocate memory, Velox retries the allocation by shrinking the data cache. | ||
| Therefore, the data cache size is automatically adjusted in response to the query memory usage change. | ||
| See `Memory Management - Velox Documentation <https://facebookincubator.github.io/velox/develop/memory.html>`_ | ||
| for more information about Velox's data cache. | ||
|
|
||
| Configuration Properties | ||
| ------------------------ | ||
| See `Configuration Properties | ||
| <https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties.rst#cache-properties>`_ | ||
| for AsyncDataCache related configuration properties. | ||
|
|
||
| ========= | ||
| SSD Cache | ||
| ========= | ||
|
|
||
| Background | ||
| ---------- | ||
| The in-memory data cache (AsyncDataCache) is configured to use SSD when provided. | ||
| The SSD serves as an extension for the AsyncDataCache. | ||
| This helps mitigate the number of reads from slower storage. | ||
|
|
||
| Configuration Properties | ||
majetideepak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ------------------------ | ||
| See `Configuration Properties | ||
| <https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties.rst#cache-properties>`_ | ||
| for SSD Cache related configuration properties. | ||
|
|
||
| Metrics | ||
| ------- | ||
| There are SSD cache relevant metrics that Velox emits during query execution and runtime. | ||
| See `Debugging Metrics <./debugging/metrics.rst>`_ and `Monitoring Metrics <../monitoring/metrics.rst>`_ for more details. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now doubting the need for this PR. Do we need this in addition to what we have in the PrestoC++ doc?
This content looks more like PrestoC++ documentation content with the references to the Velox doc.
All the content here sounds more like at the PrestoC++ level rather than Velox. The Velox documentation would rather go into detail as to how it works rather than talk about the operationalization and some vague statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czentgr I agree, I will close this PR since the cache configs PR already was merged for Prestissimo.