Add IPPREFIX to/from VARCHAR casting#11309
Closed
mohsaka wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Add IPPREFIX to/from VARCHAR casting#11309mohsaka wants to merge 1 commit intofacebookincubator:mainfrom
mohsaka wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
mohsaka
force-pushed
the
ipprefix_cast_varchar
branch
from
6c84027 to
878388f
Compare
mohsaka
force-pushed
the
ipprefix_cast_varchar
branch
5 times, most recently
from
fd28300 to
de55f21
Compare
This was referenced Oct 29, 2024
aditi-pandit
reviewed
Nov 5, 2024
aditi-pandit
reviewed
Nov 5, 2024
This was referenced Nov 6, 2024
mohsaka
force-pushed
the
ipprefix_cast_varchar
branch
2 times, most recently
from
f6bbdce to
53b1d30
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
Summary: When switching from varbinary based to row based ipprefix the typeof was not changed. Changed here to fix the issue. Split from: #11309 Pull Request resolved: #11449 Reviewed By: yuandagits Differential Revision: D65612144 Pulled By: kevinwilfong fbshipit-source-id: 8fc716f0c8e78a1355727b2c1179c9955828c16c
czentgr
reviewed
Nov 8, 2024
mohsaka
force-pushed
the
ipprefix_cast_varchar
branch
from
53b1d30 to
2ee8c07
Compare
mohsaka
force-pushed
the
ipprefix_cast_varchar
branch
from
2ee8c07 to
b9bdeab
Compare
Collaborator
Author
|
Merged in via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IPPREFIX to/from VARCHAR casting.
Fuzzer changes here:
#11209