Skip to content

OrcReaderTest: Copy test input files to the binary dir#10588

Closed
zuyu wants to merge 1 commit intofacebookincubator:mainfrom
zuyu:orc-cp-test-files
Closed

OrcReaderTest: Copy test input files to the binary dir#10588
zuyu wants to merge 1 commit intofacebookincubator:mainfrom
zuyu:orc-cp-test-files

Conversation

@zuyu
Copy link
Contributor

@zuyu zuyu commented Jul 28, 2024

This is a follow-up PR of #10194 to address test failures in the out-of-source build:

E20240728 Exceptions.h:67] Line: velox/velox/common/file/File.cpp:112, Function:LocalReadFile, Expression:  No such file or directory: cmake-build-debug/velox/velox/dwio/orc/test/examples/TestStringDictionary.testRowIndex.orc, Source: RUNTIME, ErrorCode: FILE_NOT_FOUND
E20240728 Exceptions.h:67] Line: velox/velox/common/file/File.cpp:112, Function:LocalReadFile, Expression:  No such file or directory: cmake-build-debug/velox/velox/dwio/orc/test/examples/complextypes_iceberg.orc, Source: RUNTIME, ErrorCode: FILE_NOT_FOUND
E20240728 Exceptions.h:67] Line: velox/velox/common/file/File.cpp:112, Function:LocalReadFile, Expression:  No such file or directory: cmake-build-debug/velox/velox/dwio/orc/test/examples/orc_index_int_string.orc, Source: RUNTIME, ErrorCode: FILE_NOT_FOUND
E20240728 Exceptions.h:67] Line: velox/velox/common/file/File.cpp:112, Function:LocalReadFile, Expression:  No such file or directory: cmake-build-debug/velox/velox/dwio/orc/test/examples/TestOrcFile.testDate1900.orc, Source: RUNTIME, ErrorCode: FILE_NOT_FOUND
E20240728 Exceptions.h:67] Line: velox/velox/common/file/File.cpp:112, Function:LocalReadFile, Expression:  No such file or directory: cmake-build-debug/velox/velox/dwio/orc/test/examples/orc_all_type.orc, Source: RUNTIME, ErrorCode: FILE_NOT_FOUND

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2024
@netlify
Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 40556fb
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66a61132749cb90009c30feb

@jinchengchenghh
Copy link
Collaborator

Velox won't copy files to build folder, If you use vscode to debug, you can try https://github.com/apache/incubator-gluten/blob/main/docs/developers/NewToGluten.md#velox-debug.

Otherwise, you could search which command is similar to cwd in vscode launch.json or copy the folder by yourself.

@jinchengchenghh
Copy link
Collaborator

You can also run the test from TestFile folder such as

/mnt/DP_disk1/code/velox/velox/dwio/parquet/tests/reader# /mnt/DP_disk1/code/velox/build/velox/dwio/parquet/tests/reader/velox_dwio_parquet_reader_test

@zuyu
Copy link
Contributor Author

zuyu commented Jul 29, 2024

@jinchengchenghh https://github.com/apache/incubator-gluten/blob/main/docs/developers/NewToGluten.md#velox-debug has fixed in #8460. You probably want to update the doc in Apache Gluten (incubator).

@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jul 30, 2024
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in ec842f1.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit ec842f18.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@zuyu zuyu deleted the orc-cp-test-files branch July 31, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants