Add support for parquet_writer_version session property#10419
Closed
svm1 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Add support for parquet_writer_version session property#10419svm1 wants to merge 1 commit intofacebookincubator:mainfrom
parquet_writer_version session property#10419svm1 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
svm1
changed the title
parquet_writer_version session propertyparquet_writer_version session property
svm1
force-pushed
the
parq_datapage_version
branch
2 times, most recently
from
c8edd7f to
46f4792
Compare
svm1
force-pushed
the
parq_datapage_version
branch
from
d5fe5f8 to
4f9f645
Compare
yingsu00
reviewed
Jul 22, 2024
| if (parquetDataPageVersion == "PARQUET_1_0") { | ||
| options->parquetDataPageVersion = | ||
| dwio::common::ParquetDataPageVersion::V1; | ||
| } else { |
Contributor
There was a problem hiding this comment.
Check if it's "PARQUET_2_0", otherwise throw an error
Collaborator
Author
There was a problem hiding this comment.
My thinking was that parquetDataPageVersion value must be either "PARQUET_1_0" or "PARQUET_2_0" if we've reached this point, as I added validation in the HiveConfig::parquetDataPageVersion() function from which this value is fetched:
VELOX_CHECK(
parquetDataPageVersion == "PARQUET_1_0" ||
parquetDataPageVersion == "PARQUET_2_0",
"Invalid Parquet version.");
| const date::time_zone* sessionTimezone_{nullptr}; | ||
| }; | ||
|
|
||
| enum class ParquetDataPageVersion { V1, V2 }; |
Contributor
There was a problem hiding this comment.
The Parquet specific options are better to be in Parquet writer options. It'll be better to rebase this PR after #10470 is merged.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the Presto session property
parquet_writer_version, which is currently ignored by Velox, to toggle the parquet writer datapage version (V1 or V2). The value can be set as a session property or can be provided in the Hive config. Defaults to V2.