Optimize cast(uuid as varchar)#10361
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova:export-D59229653
Closed
Optimize cast(uuid as varchar)#10361mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom mbasmanova:export-D59229653
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova:export-D59229653
Conversation
Summary:
boost::lexical_cast used to implement cast(uuid as varchar) is very slow.
Replace with custom optimization.
Microbenchmark shows 20x improvement.
The benchmark compares uuid() with cast(uuid() as varchar). The latter includes the code of the former plus the cost of the cast. Before the change, uuid() + cast was 16s, 10s more than uuid() alone. After the change, uuid() + cast() is just 0.5s more.
Before:
```
============================================================================
[...]hmarks/ExpressionBenchmarkBuilder.cpp relative time/iter iters/s
============================================================================
cast##no_cast 6.33s 157.86m
cast##as_varchar 16.54s 60.45m
```
After:
```
============================================================================
cast##no_cast 6.29s 159.10m
cast##as_varchar 6.81s 146.74m
----------------------------------------------------------------------------
```
Profile before the optimization: {F1735048022}
Differential Revision: D59229653
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59229653 |
xiaoxmeng
approved these changes
Jul 1, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@mbasmanova Nice fix. Thanks!
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
boost::lexical_cast used to implement cast(uuid as varchar) is very slow.
Replace with custom optimization.
Microbenchmark shows 20x improvement.
The benchmark compares uuid() with cast(uuid() as varchar). The latter includes the code of the former plus the cost of the cast. Before the change, uuid() + cast was 16s, 10s more than uuid() alone. After the change, uuid() + cast() is just 0.5s more.
Before:
After:
Profile before the optimization: {F1735048022}
Differential Revision: D59229653