Clean up yearTimestampWithTimezone test#10344
Closed
DanielHunte wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Clean up yearTimestampWithTimezone test#10344DanielHunte wants to merge 1 commit intofacebookincubator:mainfrom
DanielHunte wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: There is a lot more clean up to be done in this file, this just targets a single test fixture. Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed. Differential Revision: D59135897
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59135897 |
pedroerp
approved these changes
Jun 28, 2024
Contributor
pedroerp
left a comment
pedroerp
left a comment
There was a problem hiding this comment.
Looks great, thanks for the refactor!
Contributor
|
This pull request has been merged in 2965680. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There is a lot more clean up to be done in this file, this just targets a single test fixture.
Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed.
Differential Revision: D59135897