Add singularity compatibility #1608 #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 30, 2023
|
Hi everyone, would it be possible to merge this PR? Is there a particular blocking point preventing the merge? I would be happy to contribute, if this needs more work. |
jrapin
approved these changes
Aug 16, 2023
|
@gwenzek can this be moved to the base executor class? I expect the same logic can be applied to LocalExecutor (but not DebugExecutor) and any other executor based on processes Merging anyway since this version has been version for some time now, this can unblock people, moving to the base Executor should not be a breaking change, and you're not available right now ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long awaited feature request #1608
the feature has been tested for some time.
This adds a "python" variable to "SlurmExecutor".
SlurmExecutor will use this given python executable/command to launch job.
The user is responsible to escape the string, which allows to pass singularity command like
singularity --nv exec my_image.sif /opt/python3.8/bin/pythonIn
AutoExecutoryou can useAutoExecutor(slurm_python="singularity --nv exec my_image.sif /opt/python3.8/bin/python")